Move db module from spacetimedb_sats to spacetimedb_lib
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
commented
Jul 15, 2024
| impl From<ProductType> for Vec<ColumnDef> { | ||
| fn from(value: ProductType) -> Self { | ||
| impl ColumnDef { | ||
| pub fn from_product_type(value: ProductType) -> Vec<ColumnDef> { |
There was a problem hiding this comment.
This change was necessary due to the orphan rule (you can't impl From<T> for Vec<StructDefinedInThisCrate>)
Update bindings crate Update table crate Update vm crate Update bindings-macro crate Update rust-wasm-test module Update core crate Update cli crate Update bench crate Remove needless dependency Placate clippy Cargo fmt Placate clippy once more Back, foul beast Fix compile error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
As well as the
relationmodule.Split this out of the schema rewrite, it is largely a find-replace change (except for one method that had to be renamed due to orphan rule).
API and ABI breaking changes
This is an API-breaking change, but curiously not an ABI-breaking change.
Expected complexity level and risk
1
Testing
Tests and smoketests pass locally, except for the C# issues floating around. (e: this has now been fixed.)