ColList: preserve list order on list.push(..)
#1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/col-actual-list
branch
from
d0d1445 to
fa56b2b
Compare
bfops
added
release-any
kazimuth
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Preserve the list order of
ColListfor e.g.,col_list![2, 0]by heapifying in those cases.This might not be the optimal performance solution, but this fixes the bug while preserving that
size_of::<ColList> == 8and that it is still inline in the common case.API and ABI breaking changes
Rather unlikely that anyone relied on this bug.
Expected complexity level and risk
2, some unsafe and someone might have relied on this bug.
Testing