Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoketests: Add test for module hotswapping #1403

Merged
merged 1 commit into from
Jul 8, 2024
Merged

smoketests: Add test for module hotswapping #1403

merged 1 commit into from
Jul 8, 2024

Conversation

kim
Copy link
Contributor

@kim kim commented Jun 12, 2024

The test establishes a subscription, updates the module (clear=False) and asserts that the subscription was not terminated and received an update made using the new module.


Depends-on: #1343 #1367


# Update the module
self.write_module_code(self.MODULE_CODE_B)
self.publish_module(name, clear=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these synchronous calls?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything interacting with the database just shells out to the CLI. So, yes.

Base automatically changed from noa/subscribe-subcommand to master June 14, 2024 09:41
@kim kim force-pushed the kim/hot-smoke branch from 9f7a6b4 to e6f42c9 Compare June 14, 2024 09:45
@kim kim changed the base branch from master to kim/smoke-dangling June 14, 2024 09:46
@kim kim force-pushed the kim/smoke-dangling branch from a261d07 to 5c5d80c Compare June 14, 2024 10:02
@kim kim force-pushed the kim/hot-smoke branch from e6f42c9 to 0898568 Compare June 14, 2024 10:03
@kim kim force-pushed the kim/smoke-dangling branch from 5c5d80c to 35c546d Compare June 14, 2024 10:17
@kim kim force-pushed the kim/hot-smoke branch from 0898568 to 8b8d87f Compare June 14, 2024 10:17
@kim kim force-pushed the kim/smoke-dangling branch from 35c546d to 1aed13f Compare June 14, 2024 11:02
@kim kim force-pushed the kim/hot-smoke branch from 8b8d87f to 7768980 Compare June 14, 2024 11:02
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Jun 17, 2024
Base automatically changed from kim/smoke-dangling to master June 20, 2024 06:39
The test establishes a subscription, updates the module (`clear=False`)
and asserts that the subscription was not terminated and received an
update made using the new module.
@kim kim force-pushed the kim/hot-smoke branch from 7768980 to 9fe9d2c Compare June 24, 2024 17:42
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging this.

@cloutiertyler cloutiertyler added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@kim kim added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit c8259bf Jul 8, 2024
7 checks passed
@kim kim deleted the kim/hot-smoke branch July 8, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants