-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smoketests: Add test for module hotswapping #1403
Conversation
|
||
# Update the module | ||
self.write_module_code(self.MODULE_CODE_B) | ||
self.publish_module(name, clear=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these synchronous calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything interacting with the database just shells out to the CLI. So, yes.
The test establishes a subscription, updates the module (`clear=False`) and asserts that the subscription was not terminated and received an update made using the new module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging this.
The test establishes a subscription, updates the module (
clear=False
) and asserts that the subscription was not terminated and received an update made using the new module.Depends-on:
#1343#1367