Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflows support workflow_dispatch event #1289

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented May 23, 2024

Description of Changes

Add workflow_dispatch event support to ci.yml.

This allows us to trigger workflow runs manually (see benchmarks).

API and ABI breaking changes

No

Expected complexity level and risk

2

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels May 23, 2024
@bfops bfops requested a review from kazimuth May 23, 2024 18:57
@bfops bfops changed the title Add a workflow_dispatch event to the CI workflow CI workflows support workflow_dispatch event May 23, 2024
@bfops bfops marked this pull request as ready for review May 23, 2024 18:58
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, 👍

Copy link
Contributor

@kurtismullins kurtismullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one comment: The Pull Request CI is usually a combination of a given branch merged with master to make sure that it will behave as expected when merged into master. This appears to fetch just the branch. It might not make as much sense to use "Pull Request Number" as it would to maybe use commit or branch_name for example.

That is just a nitpick -- otherwise it looks good to me!

@bfops
Copy link
Collaborator Author

bfops commented May 24, 2024

Nice! Just one comment: The Pull Request CI is usually a combination of a given branch merged with master to make sure that it will behave as expected when merged into master. This appears to fetch just the branch. It might not make as much sense to use "Pull Request Number" as it would to maybe use commit or branch_name for example.

That is just a nitpick -- otherwise it looks good to me!

That's a good point, there might be an opportunity for better UX here. I can also see an argument for keeping inputs the same between workflows, though.

I'm going to merge as-is, but I promise not to take it personally if someone else cares enough to changes it!

@bfops bfops added this pull request to the merge queue May 24, 2024
Merged via the queue into master with commit 93b9d76 May 24, 2024
11 checks passed
@bfops bfops deleted the bfops/ci-dispatch branch May 24, 2024 15:41
@bfops
Copy link
Collaborator Author

bfops commented May 24, 2024

I have successfully triggered a CI workflow from the Actions page!

@bfops bfops mentioned this pull request May 24, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants