-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI workflows support workflow_dispatch
event
#1289
Conversation
workflow_dispatch
event to the CI workflowworkflow_dispatch
event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one comment: The Pull Request CI is usually a combination of a given branch merged with master to make sure that it will behave as expected when merged into master. This appears to fetch just the branch. It might not make as much sense to use "Pull Request Number" as it would to maybe use commit
or branch_name
for example.
That is just a nitpick -- otherwise it looks good to me!
That's a good point, there might be an opportunity for better UX here. I can also see an argument for keeping inputs the same between workflows, though. I'm going to merge as-is, but I promise not to take it personally if someone else cares enough to changes it! |
I have successfully triggered a CI workflow from the |
Description of Changes
Add
workflow_dispatch
event support toci.yml
.This allows us to trigger workflow runs manually (see benchmarks).
API and ABI breaking changes
No
Expected complexity level and risk
2
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
workflow_dispatch
step until it's merged