merge_apply_inserts/deletes: do metrics work once per table, not per row
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
approved these changes
May 23, 2024
| @@ -399,21 +399,25 @@ impl CommittedState { | |||
| let pv = table | |||
| .delete(blob_store, row_ptr, |row| row.to_product_value()) | |||
| .expect("Delete for non-existent row!"); | |||
There was a problem hiding this comment.
If this panics, then metrics count in prometheus will permanently become incosistent with table but then we will also have other bigger troubles?
There was a problem hiding this comment.
Yeah we'd be in pretty big trouble, as it means that the invariant stated above does not hold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rather than doing metrics work once per row in
merge_apply_inserts/deletes, just take the per-table lengths and update metrics once per table.API and ABI breaking changes
None
Expected complexity level and risk
1