Update C# codegen to consistent filtering rules #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
- Limit types as per proposal. - Add `Query` client-side SDK helper for API parity with server-side modules (on client-side it's a simple wrapper around Iter + Where). - Change return type of `FilterBy` to always be iterable, with new `FindBy` function for unique fields. - Simplify the way primary keys are handled - must go with clockworklabs/com.clockworklabs.spacetimedbsdk#93 for the client SDK counterpart.
RReverser
force-pushed
the
ingvar/consistent-filtering-csharp-client
branch
from
8f3a6b8 to
8ac9272
Compare
jdetter
approved these changes
May 28, 2024
RReverser
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
May 28, 2024
## Description of Changes As a result of the consistent filtering rules proposal (clockworklabs/SpacetimeDB#1256), all equatable types are now natively equatable in C# as well. This allows us to compare objects directly, without holding and comparing AlgebraicValue in the entries map as well, which has a bit of a domino effect and allows to optimise, simplify or even remove some parts of the SDK. ## API - [x] This is an API breaking change to the SDK New filtering rules limit types on which filtering can be done, as well as change the return type of `FilterBy` functions to always be iterable. ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#1277
RReverser
added a commit
that referenced
this pull request
May 28, 2024
Fixes regression accidentally introduced in #1277: if FindBy returns null, FilterBy will return an iterable with a single null item instead of an empty iterable.
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 31, 2024
* Fix FilterBy regression in C# Fixes regression accidentally introduced in #1277: if FindBy returns null, FilterBy will return an iterable with a single null item instead of an empty iterable. * Fix snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Queryclient-side SDK helper for API parity with server-side modules (on client-side it's a simple wrapper around Iter + Where).FilterByto always be iterable, with newFindByfunction for unique fields.API and ABI breaking changes
Limits equatable types and changes return type of
FilterByfunctions as per proposal.Expected complexity level and risk
2
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!