-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent filtering in Rust client + minor fixes #1275
Conversation
This needs to wait for server-side API break to be implemented as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, more consistent. I love reviewing these codegen changes by just looking at changes to the generated code lol.
Heh doesn't help that in this case we didn't have baseline codegen snapshot before those changes - that's why I kept the commit introducing that baseline separate. |
Description of Changes
HashSet
.cursive-chat
'smodule_bindings
folder with a symlink toquickstart-chat
's one (as they're supposed to be the same, and this makes diffs smaller).API and ABI breaking changes
Consistent filtering rules proposal limits types on which filtering can be done, as well as changes
filter_by
functions to always return an opaque iterator instead of iterator or option as it did before.Expected complexity level and risk
1
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
module_bindings
in the repo manually.module_bindings
.