Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent filtering in Rust client + minor fixes #1275

Merged
merged 10 commits into from
May 28, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

  • Extend codegen tests to Rust.
  • Fix found issue with non-deterministic order of imports in generated code caused by usage of HashSet.
  • Replace cursive-chat's module_bindings folder with a symlink to quickstart-chat's one (as they're supposed to be the same, and this makes diffs smaller).
  • Implement Rust client part of Implement consistent filtering rules proposal #1256.
  • Regenerated tests.

API and ABI breaking changes

Consistent filtering rules proposal limits types on which filtering can be done, as well as changes filter_by functions to always return an opaque iterator instead of iterator or option as it did before.

Expected complexity level and risk

1

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Ran codegen tests.
  • Regenerated all module_bindings in the repo manually.
  • Reran SDK tests that depend on module_bindings.

@RReverser RReverser requested review from cloutiertyler and gefjon May 22, 2024 14:03
This needs to wait for server-side API break to be implemented as well.
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, more consistent. I love reviewing these codegen changes by just looking at changes to the generated code lol.

@RReverser
Copy link
Contributor Author

I love reviewing these codegen changes by just looking at changes to the generated code lol.

Heh doesn't help that in this case we didn't have baseline codegen snapshot before those changes - that's why I kept the commit introducing that baseline separate.

@RReverser RReverser added this pull request to the merge queue May 27, 2024
@RReverser RReverser removed this pull request from the merge queue due to a manual request May 27, 2024
@RReverser RReverser added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit f5a13b6 May 28, 2024
6 checks passed
@RReverser RReverser deleted the ingvar/consistent-filtering-rust-client branch May 29, 2024 14:28
@bfops bfops added breaks library compatibility This change breaks the SpacetimeDB library interface and removed breaks library compatibility This change breaks the SpacetimeDB library interface labels Jun 4, 2024
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants