feat(1231): Basic query cardinality estimation #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
requested changes
May 21, 2024
Centril
force-pushed
the
joshua/feat/1231/cardinality-estimation
branch
from
1cf2ea2 to
401a7a5
Compare
Centril
approved these changes
May 22, 2024
|
@joshua-spacetime Since you are rather busy, I took the liberty of applying my suggestions myself. They simplified things, especially the tests, quite a bit. If you are as well, I am happy to merge the PR now, and the range stuff we can defer to a different PR (although feel free to comment on that,...). |
mamcx
reviewed
May 22, 2024
| use crate::db::relational_db::Tx; | ||
| use spacetimedb_primitives::{ColList, TableId}; | ||
| use spacetimedb_vm::expr::{Query, QueryExpr, SourceExpr}; | ||
|
|
There was a problem hiding this comment.
The way this is written is to me not estimated number of rows but MAXIMUM estimated number of rows.
There was a problem hiding this comment.
This is true, although the plan is that this will become more accurate over time as we add more stats.
This patch implements basic cardinality estimation for QueryExpr. It utilizes table cardinalities and number of distinct values for index related operators.
Centril
force-pushed
the
joshua/feat/1231/cardinality-estimation
branch
from
36b29e9 to
7b3509a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch implements basic cardinality estimation for QueryExpr. It utilizes table cardinalities and number of distinct values for index related operators.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Tests are added.