Reserve sequence range for system tables #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
reviewed
May 21, 2024
Centril
reviewed
May 21, 2024
crates/core/src/db/datastore/locking_tx_datastore/committed_state.rs
Outdated
Show resolved
Hide resolved
|
Might conflict a bit with #1263, so I'll wait with merging mine. |
Reserves an unreasonably large number of sequence values for use by system tables. This means that user-created tables will draw id values starting from the reserved range + 1, as opposed to number of values taken by system tables + 1. Adding new system tables is thus unlikely to interfere with already-assigned values in existing databases.
kim
commented
May 21, 2024
| /// | ||
| /// However unlikely it may seem, it is advisable to check for overflow in the | ||
| /// test suite when adding sequences to system tables. | ||
| pub(crate) const ST_RESERVED_SEQUENCE_RANGE: u32 = 4096; |
There was a problem hiding this comment.
I wonder if this should be equal to SEQUENCE_PREALLOCATION_AMOUNT (sadly defined in the sats crate).
I have deliberately used ST_RESERVED_SEQUENCE_RANGE to set the allocated value of system sequence, so changing the former should not break anything.
There was a problem hiding this comment.
Equal as in ST_RESERVED_SEQUENCE_RANGE = SEQUENCE_PREALLOCATION_AMOUNT I mean.
There was a problem hiding this comment.
I don't think they really should be related tbh, they serve different purposes, even if they are used for similar things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserves an unreasonably large number of sequence values for use by system tables. This means that user-created tables will draw id values starting from the reserved range + 1, as opposed to number of values taken by system tables + 1.
Adding new system tables is thus unlikely to interfere with already-assigned values in existing databases.
API and ABI breaking changes
Breaks existing databases due to id conflicts.
Expected complexity level and risk
1
Testing
Should be covered by smoke tests.