Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable branches from C# generate #1247

Merged
merged 1 commit into from
May 18, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

These branches are already inside of if is_unique {} else { ... } branch, so is_unique can never be true.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

These branches are already inside of `if is_unique {} else { ... }` branch, so `is_unique` can never be `true`.
@RReverser RReverser requested review from jdetter and kazimuth May 17, 2024 18:43
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RReverser RReverser enabled auto-merge May 17, 2024 23:04
@RReverser RReverser added this pull request to the merge queue May 18, 2024
Merged via the queue into master with commit c665503 May 18, 2024
7 checks passed
@RReverser RReverser deleted the ingvar/csharp-rm-impossible branch May 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants