Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for select * from B join A on B.y = A.x #1238

Merged
merged 1 commit into from
May 15, 2024
Merged

Add test for select * from B join A on B.y = A.x #1238

merged 1 commit into from
May 15, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 15, 2024

Description of Changes

Adds a test for a join with different column names in the ON condition.

@Centril Centril requested review from mamcx and gefjon May 15, 2024 18:18
mamcx
mamcx approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Centril Centril enabled auto-merge May 15, 2024 18:22
@Centril Centril added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 5bf6b6c May 15, 2024
7 checks passed
@Centril Centril deleted the centril/compile_check_bad_field branch May 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcx mamcx mamcx approved these changes

@gefjon gefjon Awaiting requested review from gefjon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Centril @mamcx