Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS for rust-toolchain.toml #1221

Merged
merged 2 commits into from
May 14, 2024
Merged

Add CODEOWNERS for rust-toolchain.toml #1221

merged 2 commits into from
May 14, 2024

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented May 13, 2024

Description of Changes

Adds a CODEOWNERS entry for rust-toolchain.toml.

This is to prevent surprise changes to the Rust version, which may have adverse downstream impacts.

API and ABI breaking changes

No.

Expected complexity level and risk

0

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

@bfops bfops requested a review from cloutiertyler May 13, 2024 18:40
@bfops bfops marked this pull request as ready for review May 13, 2024 18:43
@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels May 13, 2024
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@bfops bfops added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2024
@bfops bfops added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit 52c6df6 May 14, 2024
17 checks passed
@bfops bfops deleted the bfops/codeowners branch May 14, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants