Fix select * from * #1218
Merged
Fix select * from * #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which doesn't pass, because we broke it.
coolreader18
force-pushed
the
phoebe/select-star-broken
branch
from
1276190 to
7ba381e
Compare
gefjon
approved these changes
May 13, 2024
coolreader18
force-pushed
the
phoebe/select-star-broken
branch
from
7ba381e to
f2fd117
Compare
coolreader18
force-pushed
the
phoebe/select-star-broken
branch
from
f2fd117 to
4f6985d
Compare
|
@bfops please do a functional test on this with the C# SDK and make sure that it works properly |
2 tasks
bfops
pushed a commit
that referenced
this pull request
May 14, 2024
* Add SDK test for `SELECT * FROM *` Which doesn't pass, because we broke it. * Fix select * from * --------- Co-authored-by: Phoebe Goldman <[email protected]>
bfops
pushed a commit
that referenced
this pull request
May 15, 2024
* Add SDK test for `SELECT * FROM *` Which doesn't pass, because we broke it. * Fix select * from * --------- Co-authored-by: Phoebe Goldman <[email protected]>
bfops
pushed a commit
that referenced
this pull request
May 15, 2024
* Add SDK test for `SELECT * FROM *` Which doesn't pass, because we broke it. * Fix select * from * --------- Co-authored-by: Phoebe Goldman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We should really remove this.
Fixes #1199