Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacetime build uses --project-path param #1212

Merged
merged 4 commits into from
May 9, 2024

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented May 9, 2024

Description of Changes

Please describe your change, mention any related tickets, and so on here.

  • spacetime publish and spacetime generate both use --project-path <path>, so spacetime build should use the same.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Breaks the CLI params

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • spacetime build --project-path <path> works as expected.

@jdetter jdetter requested a review from bfops May 9, 2024 15:21
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - let's see if it breaks something!

@jdetter
Copy link
Collaborator Author

jdetter commented May 9, 2024

Our CI is happy and this is another step towards a more cohesive CLI 👍

@jdetter jdetter added this pull request to the merge queue May 9, 2024
Merged via the queue into master with commit b275dbf May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants