Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrudExpr::{Delete, Insert, Update}: only DbTables are possible, so cleanup InMem path #1211

Merged
merged 4 commits into from
May 10, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 8, 2024

Description of Changes

  • Commit 1 removes a bunch of methods that were unused.
  • Commit 2 realizes that all of this Table business is in fact redundant and can be removed as SourceExpr::InMem is impossible and thus we can assume we have a DbTable.
  • Commit 3 moves CrudExpr::Update's fn eval_query logic to its own method, like all the other cases, for readability and consistency.
  • Commit 4 uses TxMode::unwrap_mut that was introduced in commit 2 in 2 more cases.

API and ABI breaking changes

None

Expected complexity level and risk

1

@Centril Centril changed the title Remove dead code wrt. Table CrudExpr::{Delete, Insert, Update}: only DbTables are possible, so cleanup InMem path May 8, 2024
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mamcx
Copy link
Contributor

mamcx commented May 9, 2024

NOTE: We need to recover the cases for full CRUD operations on MemTable when we revisit the plans for the vm

@Centril Centril added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit 4e444bd May 10, 2024
7 checks passed
@Centril Centril deleted the centril/dce-table branch May 13, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants