Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some impls that were dead code #1210

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove some impls that were dead code #1210

merged 1 commit into from
May 10, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 7, 2024

Description of Changes

  • Remove impl From<FieldName> for Box<ColumnOp>
  • Remove impl From<AlgebraicValue> for Box<ColumnOp>

Both are dead code.

mamcx
mamcx approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Centril Centril added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit 78696e5 May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcx mamcx mamcx approved these changes

@coolreader18 coolreader18 Awaiting requested review from coolreader18

@joshua-spacetime joshua-spacetime Awaiting requested review from joshua-spacetime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Centril @mamcx