Bump to Rust 1.78 #1205
Merged
Bump to Rust 1.78 #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
added
the
breaks library compatibility
Centril
approved these changes
May 6, 2024
| @@ -129,7 +129,7 @@ impl WasmInstanceEnv { | |||
| /// Signal to this `WasmInstanceEnv` that a reducer call is beginning. | |||
| pub fn start_reducer(&mut self, name: &str) { | |||
| self.reducer_start = Instant::now(); | |||
| self.reducer_name = name.to_owned(); | |||
| name.clone_into(&mut self.reducer_name); | |||
There was a problem hiding this comment.
Didn't know this was being added, neat!
There was a problem hiding this comment.
Yeah, it's a nice lint! Now I feel like I have to document all the overrides of clone_into in std...
Centril
approved these changes
May 7, 2024
|
I had expected this to improve the subscription benchmarks due to the LLVM 18 bump, but it seems it didn't. Although, this may have improved perf elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
1.78 brings
#[diagnostic::on_unimplemented], which lets you customize error messages when a type doesn't implement a trait. I have a branch that uses it to improve reducer & table type errors.API and ABI breaking changes
MSRV bump, but that's usually not a big deal. understandable if we wanna hold off on it for a bit.
Expected complexity level and risk
1