Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: rename DbEventArgs to ReducerContext #1191

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

RReverser
Copy link
Contributor

Description of Changes

This is no longer an event type, so remove subclassing and rename to match the Rust API.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

1

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Checked that C# SDK tests still build.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

This is no longer an event type, so remove subclassing and rename to match the Rust API.
@RReverser RReverser requested a review from cloutiertyler May 1, 2024 15:15
@RReverser RReverser requested a review from dylanh724 May 1, 2024 15:15
@RReverser RReverser requested a review from cloutiertyler May 1, 2024 17:45
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More uniformity between module languages is great. 👍

@RReverser RReverser added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit fe44011 May 8, 2024
6 checks passed
@RReverser RReverser deleted the csharp-reducer-context branch May 22, 2024 14:59
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants