Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RowUpdate event from C# #1190

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove RowUpdate event from C# #1190

merged 1 commit into from
May 10, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

We talked about this for a while, so decided to do this in a separate PR.

Users will need to subscribe to OnInsert / OnUpdate / OnDelete separately.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

1

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Ran codegen tests and updated snapshot.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

We talked about this for a while, so decided to do this in a separate PR.
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, where was the conversation about this?

Looks good to me, though. We won't need a docs update because this isn't currently documented :^)

@RReverser RReverser added this pull request to the merge queue May 8, 2024
@RReverser RReverser removed this pull request from the merge queue due to a manual request May 8, 2024
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We looked at the BitCraft code and this seems unused - LGTM

@RReverser RReverser added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit e252b0c May 10, 2024
7 checks passed
@RReverser RReverser deleted the remove-onrowupdate branch May 10, 2024 23:10
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants