CLI - Small refactors to identity code #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
added
release-any
bfops
force-pushed
the
bfops/cli-identity-refactor
branch
from
c789897 to
049497d
Compare
bfops
commented
Apr 26, 2024
| .get_identity_config_mut(identity_or_name) | ||
| .ok_or_else(|| anyhow::anyhow!("Missing identity credentials for identity: {identity_or_name}"))?; | ||
| .get_identity_config_mut(identity) | ||
| .ok_or_else(|| anyhow::anyhow!("Missing identity credentials for identity: {identity}"))?; |
There was a problem hiding this comment.
just a rename for consistency with other code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Small refactors to some CLI code around identity management, to make review for #1140 easier.
These changes do not change any behavior.
Config.name_existsnow just usesConfig.get_identity_config_by_nameConfig.identity_existsfor parity (currently unused, used in Make identity naming more consistent + fix bugs #1140)Config.can_set_name(just used in one place, used more in Make identity naming more consistent + fix bugs #1140)API and ABI breaking changes
No
Expected complexity level and risk
1
Testing