Fix soundness hole in Table::delete + don't make & immedately drop PVs in the method
#1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/relvalue-hash
branch
2 times, most recently
from
3beedc3 to
c07882a
Compare
gefjon
approved these changes
Apr 30, 2024
Centril
force-pushed
the
centril/relvalue-hash
branch
from
c07882a to
9422149
Compare
Centril
force-pushed
the
centril/relvalue-hash
branch
from
9422149 to
0c8d972
Compare
Co-authored-by: Phoebe Goldman <[email protected]> Signed-off-by: Mazdak Farrokhzad <[email protected]>
Centril
force-pushed
the
centril/fix-delete
branch
from
bcade6a to
de291da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Table::deletewhere we didn't confirm that the row was present.Table::delete, we make a PV just to immediately drop it. FixesMutTxId::insert_row_internal: don't create PV and throw it away #1083.Future work: consider changing
Table::find_same_rowto work on&ProductValueinstead, so we don't have to insert rows temporarily anywhere.API and ABI breaking changes
None
Expected complexity level and risk
2