Implement RelValue: Eq + Hash
#1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/relvalue-hash
branch
from
8c18d96 to
04ccff0
Compare
Centril
force-pushed
the
centril/relvalue-hash
branch
4 times, most recently
from
adcb1c8 to
588f175
Compare
Centril
force-pushed
the
centril/relvalue-hash
branch
5 times, most recently
from
03f23d3 to
28de797
Compare
This was referenced Apr 22, 2024
Merged
Centril
force-pushed
the
centril/bsatn-hash-eq
branch
from
87255f0 to
5ef9bd3
Compare
Centril
force-pushed
the
centril/relvalue-hash
branch
from
28de797 to
a9bf0c0
Compare
Centril
changed the title
RelValue: Eq + Hash, RowRef: Hash + PartialEq<ProductValue>
Centril
force-pushed
the
centril/relvalue-hash
branch
from
a9bf0c0 to
3beedc3
Compare
Centril
changed the base branch from
centril/row-ref-hash
to
centril/eq-pv-row-ref
Centril
changed the title
RelValue: Eq + Hash, RowRef: Hash + PartialEq<ProductValue>RelValue: Eq + Hash
Centril
force-pushed
the
centril/eq-pv-row-ref
branch
from
9a670c5 to
91ba9db
Compare
Centril
force-pushed
the
centril/relvalue-hash
branch
from
3beedc3 to
c07882a
Compare
|
Could we get the motivation for this PR in the description? |
There ya go :) |
gefjon
approved these changes
Apr 30, 2024
Centril
force-pushed
the
centril/relvalue-hash
branch
from
c07882a to
9422149
Compare
Centril
force-pushed
the
centril/relvalue-hash
branch
from
9422149 to
0c8d972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The main goal of this PR is to make
RelValues directly usable in theIncrementalJoinalgorithm'sHashSet, therebly avoiding forcing everything toCow<'_, PV>, which is useful in some cases. To do this,RelValuemust implementEq + Hashand to do that,PVandRowRefmust be consistent in terms of equality and hash functions. The latter is achieved in a series of PRs upon which this PR is based. HavingRowRef: PartialEq<PV>and consistent hashes is also useful for the insert and delete paths.impl Eq + Hash for RelValueBased on #1164.
Fixes #1119.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
Proptests were added for the new code in previous PRs.