Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmark for deserialize json & product value #1035

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Mar 29, 2024

Description of Changes

Simple benches for deserializing json & product value, to mirror the ones for serialization.

Expected complexity level and risk

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

@mamcx mamcx added the release-any To be landed in any release window label Mar 29, 2024
@mamcx mamcx self-assigned this Mar 29, 2024
@bfops bfops added the no runtime change This change does not affect the final binaries label Apr 1, 2024
@mamcx mamcx requested a review from kazimuth June 14, 2024 18:41
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mamcx mamcx force-pushed the mamcx/benchmark_deserialize branch from 04df192 to c997334 Compare July 9, 2024 18:22
@mamcx mamcx added this pull request to the merge queue Jul 10, 2024
Merged via the queue into master with commit 80b6466 Jul 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no runtime change This change does not affect the final binaries release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants