recv-style abi #1002
Merged
recv-style abi #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
previously requested changes
Mar 21, 2024
Centril
previously requested changes
Mar 21, 2024
crates/core/src/host/instance_env.rs
Outdated
Comment on lines
51
to
48
| // For now, just send buffers over a certain fixed size. | ||
| // This is kept in sync with `DEFAULT_BUFFER_CAPACITY` in `crates/bindings/src/lib.rs` | ||
| const ITER_CHUNK_SIZE: usize = 0x20_000; |
There was a problem hiding this comment.
You could sneak this into spacetimedb-primitives as it is shared between bindings and db.
There was a problem hiding this comment.
Oh, true. errnos should probably go there as well.
coolreader18
force-pushed
the
noa/recv_abi
branch
2 times, most recently
from
9294c74 to
5086358
Compare
coolreader18
force-pushed
the
noa/recv_abi
branch
from
5086358 to
5ec11db
Compare
Centril
reviewed
Mar 27, 2024
crates/core/src/host/instance_env.rs
Outdated
Comment on lines
88
to
100
| trait ToBsatn { | ||
| fn to_bstan_extend(&self, buf: &mut Vec<u8>) -> Result<(), BsatnError>; | ||
| } | ||
| impl ToBsatn for RowRef<'_> { | ||
| fn to_bstan_extend(&self, buf: &mut Vec<u8>) -> Result<(), BsatnError> { | ||
| self.to_bsatn_extend(buf) | ||
| } | ||
| } | ||
| impl ToBsatn for RelValue<'_> { | ||
| fn to_bstan_extend(&self, buf: &mut Vec<u8>) -> Result<(), BsatnError> { | ||
| self.to_bsatn_extend(buf) | ||
| } |
There was a problem hiding this comment.
I'd call this trait ToBsatnExtend and the types could implement them directly and the inherent methods could be removed.
There was a problem hiding this comment.
I think I might do that as a follow-up - ideally it'd probably go in the sats crate or something but I'd like to try making it more generalized if we do that.
cloutiertyler
requested changes
Mar 29, 2024
|
benchmarks please |
Criterion benchmark resultsCriterion benchmark reportYOU SHOULD PROBABLY IGNORE THESE RESULTS. Criterion is a wall time based benchmarking system that is extremely noisy when run on CI. We collect these results for longitudinal analysis, but they are not reliable for comparing individual PRs. Go look at the callgrind report instead. empty
insert_1
insert_bulk
iterate
find_unique
filter
serialize
stdb_module_large_arguments
stdb_module_print_bulk
remaining
|
coolreader18
force-pushed
the
noa/recv_abi
branch
3 times, most recently
from
58e9f3f to
428fb89
Compare
coolreader18
force-pushed
the
noa/recv_abi
branch
from
428fb89 to
62d51b9
Compare
cloutiertyler
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Still need to update the csharp wasm bindings. Also, unsure about that
exhaustedout param. Might be superfluous.Expected complexity level and risk
3
Testing
smoketests pass - I think those cover all the API usage so I'm confident it doesn't crash or anything. bot-testing might be good to gauge perf improvement/impact.