Added gh-actions YAML file and config #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted: .travis.yml deleted: bin/testrepl.py modified for gh-actions: tox.ini
auvipy
requested changes
Feb 2, 2023
| @@ -1,25 +0,0 @@ | |||
| import click | |||
| from click_repl import register_repl | |||
|
|
|||
There was a problem hiding this comment.
why should we remove this file?
There was a problem hiding this comment.
that test case is not at all being involved
as pytest only searches test in tests folder, and .py files that starts with test_
I thought of adding that test in the next pr
If u want me to add that test, I can make an another commit for that
removed mypy: tox.ini
|
nvm, i've just added it as well tell me if there any queries |
auvipy
reviewed
Feb 2, 2023
auvipy
approved these changes
Feb 2, 2023
|
@auvipy Next I'm gonna remove flake8 and add black formatter instead |
|
ok |
|
and rebase the big pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these tests gonna fail, that's because of mypy
but still waiting to merge all those changes
Solves #74 and #80