Fix sanitizer bug where multiple escaped codes in a row cause invalid…

… JSON generation (#145)
cli · Nov 20, 2023 · d32c104 · d32c104
1 parent debe718
commit d32c104
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/asciisanitizer/sanitizer.go b/pkg/asciisanitizer/sanitizer.go
@@ -73,6 +73,7 @@ func (t *Sanitizer) Transform(dst, src []byte, atEOF bool) (nDst, nSrc int, err
 					// Add an escape character when necessary to prevent creating
 					// invalid JSON with our replacements.
 					repl = append([]byte{'\\'}, repl...)
+					t.addEscape = false
 				}
 				err = transfer(repl, src[:6])
 				if err != nil {

diff --git a/pkg/asciisanitizer/sanitizer_test.go b/pkg/asciisanitizer/sanitizer_test.go
@@ -24,8 +24,8 @@ func TestSanitizerTransform(t *testing.T) {
 		{
 			name:  "JSON sanitization maintains valid JSON",
 			json:  true,
-			input: `\u001B \\u001B \\\u001B \\\\u001B`,
-			want:  `^[ \\^[ \\^[ \\\\^[`,
+			input: `\u001B \\u001B \\\u001B \\\\u001B \\u001B\\u001B`,
+			want:  `^[ \\^[ \\^[ \\\\^[ \\^[\\^[`,
 		},
 		{
 			name:  "JSON C0 control character",