Dont assume cluster domain #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasPius
force-pushed
the
dont-assume-cluster-domain
branch
from
c6699fb to
a182fe4
Compare
prometherion
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on clastix/kamaji#433 and clastix/kamaji#444
This adds a
clusterDomainchart variable which is used when configuring the etcd services to accomodate clusters whose Kubernetes DNS domain is notcluster.localWithout this, etcd nodes of deployments within clusters whose domain is not
cluster.localwill not be able to reach each other through the assumed fully qualified domain name, and the cluster will never become ready.