Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require OpenSSL version number as BoringSSL doesn't define it #745

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Don't require OpenSSL version number as BoringSSL doesn't define it #745

merged 1 commit into from
Feb 14, 2025

Conversation

kmansoft
Copy link
Contributor

Fixes #744

@pabuhler
Copy link
Member

This makes some sense to me, if we are going to remove that then should probable remove the checks from the other build files as well.

@kmansoft kmansoft mentioned this pull request Feb 11, 2025
Closed
@pabuhler
Copy link
Member

Have fixed the CiFuzz build upstream.

pabuhler
pabuhler approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@pabuhler pabuhler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@pabuhler pabuhler merged commit cb9e892 into cisco:main Feb 14, 2025
38 of 39 checks passed
pabuhler added a commit to pabuhler/libsrtp that referenced this pull request Feb 14, 2025
@pabuhler
remove openssl version check
de8b1b8 
This is a follow on from cisco#744 / cisco#745 but for other
build systems.

Now that OpenSSL 1.1 is EOL there is no need to
enforce version checks.

This does not remove support for building against
OpenSSL 1.1 .
@pabuhler pabuhler mentioned this pull request Feb 14, 2025
Merged
@kmansoft
Copy link
Contributor Author

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabuhler pabuhler pabuhler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building against BoringSSL fails, easy fix
2 participants
@kmansoft @pabuhler