Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on emoji select #2249

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix crash on emoji select #2249

merged 2 commits into from
Mar 5, 2025

Conversation

ajbura
Copy link
Member

@ajbura ajbura commented Mar 4, 2025

Description

ReactEditor.focus(editor) was crashing the app when the requestClose was called by FocusTrap onDeactive after it is already called after emoji onClick. looks like a upstream issue slide-in by last slate update

Fixes #2248

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Mar 4, 2025

Preview: https://2249--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@kfiven
Copy link
Collaborator

kfiven commented Mar 4, 2025

Need a fix in message editor also.

@kfiven kfiven merged commit 5d00383 into dev Mar 5, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@kfiven kfiven deleted the fix-2248 branch March 5, 2025 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full react crash when selecting emoji from picker
2 participants