Attempt to run acceptance tests without jquery using ember canary #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cibernox looks like there is an error about a jQuery reference, see failed travis tests, |
|
Those erros have to be fixed upstream in ember. I'll try to find some. |
pixelhandler
reviewed
Apr 1, 2017
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "broccoli-asset-rev": "^2.4.5", | |||
| "ember-ajax": "^2.4.1", | |||
| "ember-ajax": "^2.5.6", | |||
There was a problem hiding this comment.
could we remove this as a dev dependency?
There was a problem hiding this comment.
I was experimenting. I believe that ember-ajax is the problem here, but at the same time mirage seems to depend on jquery implicitly.
This problem is a several layers' cake, but I'll get to the bottom of it.
cibernox
force-pushed
the
attempt-to-enable-acceptance-tests-without-jquery
branch
from
4154aa1 to
06d28af
Compare
cibernox
force-pushed
the
attempt-to-enable-acceptance-tests-without-jquery
branch
from
3471537 to
6f89e57
Compare
cibernox
force-pushed
the
attempt-to-enable-acceptance-tests-without-jquery
branch
from
0bc03e8 to
d568549
Compare
cibernox
force-pushed
the
attempt-to-enable-acceptance-tests-without-jquery
branch
from
7c5ba15 to
0287540
Compare
|
@rwjblue @pixelhandler It's alive! We can write apps and run its tests without using jQuery at all.
This uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After emberjs/ember.js#15065 was merged in master, lets see if acceptance tests run without jquery.