Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Python commands in tox in isolated and strict mode #562

Merged

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Nov 10, 2022

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

N/A

❓ What is the current behavior? (You can also link to an open issue here)

Regular Python runs.

❓ What is the new behavior (if this is a feature change)?

Strict and isolated Python runs are embedded in tox.

πŸ“‹ Other information:

N/A

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@webknjaz webknjaz added the enhancement Improvement label Nov 10, 2022
@webknjaz webknjaz changed the title Run Python commands in tox in isolated mode Run Python commands in tox in isolated and strict mode Nov 10, 2022
@webknjaz webknjaz force-pushed the maintenance/tox-isolated-and-optimized-python branch 4 times, most recently from b2b8ad6 to 8eb9e32 Compare November 11, 2022 02:50
@webknjaz webknjaz force-pushed the maintenance/tox-isolated-and-optimized-python branch from 8eb9e32 to 787ffb5 Compare November 11, 2022 02:55
@webknjaz webknjaz enabled auto-merge November 11, 2022 03:11
@webknjaz webknjaz disabled auto-merge November 11, 2022 03:29
@webknjaz webknjaz merged commit f0f9764 into cherrypy:main Nov 11, 2022
@webknjaz webknjaz deleted the maintenance/tox-isolated-and-optimized-python branch November 11, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant