Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL error: [Errno 0] Error is present also on Python 3.7 #180

Merged
merged 5 commits into from
Apr 25, 2019
Merged

SSL error: [Errno 0] Error is present also on Python 3.7 #180

merged 5 commits into from
Apr 25, 2019

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Mar 2, 2019

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

cherrypy/cherrypy#1618

❓ What is the current behavior? (You can also link to an open issue here)

cherrypy/cherrypy#1618
Error is still present with Python 3.7.2, as reported by users on Windows and Linux machines.

❓ What is the new behavior (if this is a feature change)?

Always suppress this error.

πŸ“‹ Other information:

πŸ“‹ Checklist:

  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@Safihre
Copy link
Contributor Author

Safihre commented Mar 13, 2019

Is there a chance for an update on this one?

@webknjaz
Copy link
Member

It would be nice to have some reproducible testcases for this...

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@378f099). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #180   +/-   ##
=========================================
  Coverage          ?   75.59%           
=========================================
  Files             ?       22           
  Lines             ?     3516           
  Branches          ?        0           
=========================================
  Hits              ?     2658           
  Misses            ?      858           
  Partials          ?        0

@webknjaz webknjaz merged commit 2af3b17 into cherrypy:master Apr 25, 2019
@Safihre
Copy link
Contributor Author

Safihre commented Apr 25, 2019

I think it can be reproduced with Selenium and Chrome, but that's a big additional test load.

@webknjaz
Copy link
Member

@Safihre it's fine. It could go to cron job without being executed each time. I suspect that it might be connected to TLS 1.3 and maybe ciphers mismatch...

@webknjaz
Copy link
Member

TCPdump/Wireshark dump may be useful for analysis...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants