fix: W/a sending images sent as stickers on some platforms (#4611) #4619
+137
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/sticker-to-image
branch
2 times, most recently
from
694d1b5 to
eeff507
Compare
link2xt
reviewed
Aug 15, 2023
iequidoo
force-pushed
the
iequidoo/sticker-to-image
branch
from
642e899 to
0be1d31
Compare
|
Could this change target |
iequidoo
force-pushed
the
iequidoo/sticker-to-image
branch
from
0be1d31 to
84c4725
Compare
link2xt
reviewed
Aug 25, 2023
iequidoo
force-pushed
the
iequidoo/sticker-to-image
branch
from
84c4725 to
2148a3b
Compare
Check if a sticker has at least one fully transparent corner and otherwise change the Sticker type to Image. This would fix both Android and iOS at the same time and prevent similar bug on future platforms that may get this bug like Ubuntu Touch.
…as Exif We mustn't send images with Exif as it can leak metadata such as location, camera model, etc.
iequidoo
force-pushed
the
iequidoo/sticker-to-image
branch
from
2de5ce3 to
97455ed
Compare
link2xt
approved these changes
Aug 28, 2023
|
great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if a sticker has at least one fully transparent corner and otherwise change the Sticker type to Image. This would fix both Android and iOS at the same time and prevent similar bug on future platforms that may get this bug like Ubuntu Touch.