-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable callout in the label of line annotation #740
Conversation
EDIT: solved importing LabelAnnotation class. |
@kurkle I solved CC duplication code issue using the |
I think the |
I wasn't sure. Let me try |
I have removed the callout options from label ( leaving ONLY the callout node) and adding them in the common, you don't have any fallback. Therefore to work, we should maintain all callout options and setting to undefined to have the fallback but only to centralize the defaults, not the options. |
Conflicts: types/label.d.ts types/options.d.ts
@LeeLenaleee @kurkle I have marked as ready for review. Nevertheless we should NOT merge it till mid/end of next week, giving at least 2 weeks to version 2.0.0 |
This PR is enabling the
callout
options in the label of line annotation.TODO