-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec compliant merge shares #261
Merged
+831
−161
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
494db15
start spec compliant share merging
evan-forbes 0d15df4
refactor and finish unit testing
evan-forbes 3f0d808
whoops
evan-forbes 8535122
linter gods
evan-forbes 8bae88b
fix initial changes and use constants
evan-forbes cbb5d76
use constant
evan-forbes b523831
more polish
evan-forbes f0f38a6
docs fix
evan-forbes 014a00e
review feedback: docs and out of range panic protection
evan-forbes 0896a3b
review feedback: add panic protection from empty input
evan-forbes 96eafc7
use constant instead of recalculating `ShareSize`
evan-forbes c3d897a
don't redeclare existing var
evan-forbes 28f9769
be more explicit with returned nil
evan-forbes 9ff16f5
use constant instead of recalculating `ShareSize`
evan-forbes 39ce26a
review feedback: use consistent capitalization
evan-forbes 8794411
stop accepting reserved namespaces as normal messages
evan-forbes 2b28c59
use a descriptive var name for message length
evan-forbes d118716
linter and comparison fix
evan-forbes 3ae1f79
reorg tests, add test for parse delimiter, DataFromBlock and fix evid…
evan-forbes dfe2a07
catch error for linter
evan-forbes e9f3a2e
update test MakeShares to include length delimiters for the SHARE_RES…
evan-forbes 221b0fb
minor iteration change
evan-forbes 37316e8
refactor share splitting to fix bug
evan-forbes e3736d6
fix all bugs with third and final refactor
evan-forbes 632bb37
Merge branch 'master' into evan/merge-shares
evan-forbes 3ca2afa
fix conflict
evan-forbes 0f930fd
revert unnecessary changes
evan-forbes 91c3989
review feedback: better docs
evan-forbes 043812d
reivew feedback: add comment for safeLen
evan-forbes 76d7a4b
review feedback: remove unnecessay comments
evan-forbes 1cb4030
review feedback: split up share merging and splitting into their own …
evan-forbes a88db3b
review feedback: more descriptive var names
evan-forbes 2aad8fd
fix accidental change
evan-forbes 887aa08
add some constant docs
evan-forbes 40a57c1
spelling error
evan-forbes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
review feedback: better docs
Co-authored-by: Ismail Khoffi <[email protected]>
commit 91c3989ef4a63bfe907ed8ec0dc072175fb384f4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this can serve as a kind of blueprint for the pseudo-code that could end up in the spec.