feat: support recovering parts from the mempool #1664
Merged
+373
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
cmwaters and
ninabarbakadze
and removed request for
a team
evan-forbes
reviewed
Mar 11, 2025
Comment on lines
93
to
100
| // UnmarshalledTx is an intermediary type that allows keeping the transaction metadata, | ||
| // its Key and the actual tx bytes. | ||
| // This will be used to create the parts from the local txs. | ||
| type UnmarshalledTx struct { | ||
| MetaData TxMetaData | ||
| Key types.TxKey | ||
| TxBytes []byte | ||
| } |
There was a problem hiding this comment.
in the future, we might want to consider use this type as types.Tx, as that simplifies the caching of metadata and hashes
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
evan-forbes
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1661
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments