fix: DNS TTL not respected

[ninabarbakadze]

Description

Fixes #1425

Testing

Testing DNS change is not really possible in unit tests so @smuu agreed to help me test manually

[cmwaters]

This all looks good. The only hesitation I have is that reconnectPeer is relentless. It's designed for persistent peers, not for normal peers that you want to connect to. Thus, afaik, it ignores errors and continuously redials.

When trying to reconnect, if this fails we should give up trying to connect the peer. I would suggest we add some additional input to the reconnectToPeer method which will distinguish between retry forever and retry once and if failed log an error

[ninabarbakadze]

This all looks good. The only hesitation I have is that reconnectPeer is relentless. It's designed for persistent peers, not for normal peers that you want to connect to. Thus, afaik, it ignores errors and continuously redials.

When trying to reconnect, if this fails we should give up trying to connect the peer. I would suggest we add some additional input to the reconnectToPeer method which will distinguish between retry forever and retry once and if failed log an error

For context here the peer won't try to reconnect forever. It first tries to connect 20 times with 5 second intervals(20*5=100s), then another 10 times with exponential backoff which ends in 16h(3**10 = 16hrs). it will give up after that so no change needed.

[cmwaters]

👍 Thanks @ninabarbakadze

[ninabarbakadze]

should i merge this? @cmwaters @evan-forbes

I don't think dev ops was able to test this yet

[evan-forbes]

yeah, we should merge imo