Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DataRootInclusionProof over gRPC #1602

Closed
S1nus opened this issue Feb 3, 2025 · 0 comments · Fixed by #1603
Closed

Expose DataRootInclusionProof over gRPC #1602

S1nus opened this issue Feb 3, 2025 · 0 comments · Fixed by #1603
Assignees
@rach-id
Labels
good first issue Good for newcomers

Comments

@S1nus
Copy link

S1nus commented Feb 3, 2025

Summary

DataRootInclusionProof is provided in the RPC methods of celestia-core. The ZKSync integration already has an existing connection to celestia-app via gRPC. We would like to use the existing connection rather than add a different kind of connection to the same box.

Problem Definition

Simplify an integration with ZKSync/ZKStack (Rust code here), uses gRPC celestia-app client borrowed from Astria here.

Proposal

Expose this celestia-core method over celestia-app gRPC
@rach-id rach-id added the good first issue Good for newcomers label Feb 4, 2025
@rach-id rach-id transferred this issue from celestiaorg/celestia-app Feb 4, 2025
@rach-id rach-id self-assigned this Feb 4, 2025
@rach-id rach-id mentioned this issue Feb 4, 2025
Merged
3 tasks
rach-id added a commit that referenced this issue Feb 5, 2025
@rach-id
feat: expose the data root inclusion proof over gRPC (#1603)

Verified

This commit was signed with the committer’s verified signature.
gamalielhere Gamaliel 'Yel' Padillo
GPG key ID: 573746C9C3620E60
Verified
Learn about vigilant mode
Loading
Loading status checks…
511badf 
## Description

Closes #1602

#### PR checklist

- [x] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose the data root inclusion proof over gRPC celestiaorg/celestia-core
2 participants
@S1nus @rach-id