Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: square size independent commitments #917

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Oct 26, 2022

Description

Hackathon implementation of square size independent commitments. Draft PR because still work in progress but wanted to make visible for collaboration. Post hackathon, this PR will likely be deprecated in favor of smaller, reviewable PRs that we can merge into main.

@rootulp
Copy link
Collaborator Author

rootulp commented Oct 26, 2022

This PR is bloated and should be split into:

I misinterpreted the proposal. It isn't necessary to use appconsts.MinSquareSize, it's possible to determine a message's minimalSquareSize based on the message length. Since a lot of files were modified in the pursuit of propagating that const, will close this PR in favor of a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants