Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a test branch with a larger share size #825

Closed
evan-forbes opened this issue Oct 1, 2022 · 1 comment · Fixed by #850
Closed

Create a test branch with a larger share size #825

evan-forbes opened this issue Oct 1, 2022 · 1 comment · Fixed by #850
Assignees
@rootulp
Labels
testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

We will likely want to change the share size in the future. Ideally this is a simple process, but we should try to change the size in a test branch and see what breaks. This branch would also unblock creating a similar test branch for celestia-node
@evan-forbes evan-forbes added T:investigate testing items that are strictly related to adding or extending test coverage labels Oct 1, 2022
@evan-forbes evan-forbes moved this to TODO in Celestia Node Oct 1, 2022
@evan-forbes
Copy link
Member Author

to clarify this a bit, this is basically just #711, but we don't want to merge this until we make a final decision and find out exactly what breaks

@evan-forbes evan-forbes mentioned this issue Oct 3, 2022
Closed
@rootulp rootulp self-assigned this Oct 5, 2022
@rootulp rootulp mentioned this issue Oct 7, 2022
Merged
evan-forbes added a commit that referenced this issue Oct 18, 2022
@rootulp @evan-forbes
feat!: increase share size to 512 bytes (#850)
ecc9423 
Closes #825

This is ready for review but we may not merge it b/c we haven't made a
final decision on what the share size should be

Co-authored-by: evan-forbes <[email protected]>
Repository owner moved this from TODO to Done in Celestia Node Oct 18, 2022
rach-id pushed a commit to rach-id/celestia-app that referenced this issue Nov 16, 2022
@rootulp @evan-forbes @rach-id
feat!: increase share size to 512 bytes (celestiaorg#850)
a2c4252 
Closes celestiaorg#825

This is ready for review but we may not merge it b/c we haven't made a
final decision on what the share size should be

Co-authored-by: evan-forbes <[email protected]>
cmwaters pushed a commit to celestiaorg/go-square that referenced this issue Dec 14, 2023
@rootulp @evan-forbes
feat!: increase share size to 512 bytes (#850)
42c510b 
Closes celestiaorg/celestia-app#825

This is ready for review but we may not merge it b/c we haven't made a
final decision on what the share size should be

Co-authored-by: evan-forbes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
testing items that are strictly related to adding or extending test coverage
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: increase share size to 512 bytes rootulp/celestia-app
2 participants
@rootulp @evan-forbes