Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI test for compiling proto files #284

Closed
Tracked by #514
evan-forbes opened this issue Apr 10, 2022 · 2 comments · Fixed by #555
Closed
Tracked by #514

Add CI test for compiling proto files #284

evan-forbes opened this issue Apr 10, 2022 · 2 comments · Fixed by #555
Labels
good first issue Good for newcomers

Comments

@evan-forbes
Copy link
Member

We currently do not have a test for compiling the proto files in the CI. We should add one.
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 10, 2022
@evan-forbes evan-forbes mentioned this issue Jul 1, 2022
Closed
41 tasks
rootulp added a commit to rootulp/celestia-app that referenced this issue Jul 22, 2022
@rootulp
ci: run proto-gen
143e270 
Resolves celestiaorg#284
@rootulp rootulp mentioned this issue Jul 22, 2022
Merged
evan-forbes pushed a commit that referenced this issue Jul 24, 2022
@rootulp
ci: run proto-gen (#555)
dbf2507 
Resolves #284
Repository owner moved this from TODO to Done in Celestia Node Jul 24, 2022
@adlerjohn
Copy link
Member

@rootulp @evan-forbes while #555 added a CI workflow to build proto files, it doesn't check that the generated files match the committed files. Should that check also be added to CI?

@rootulp rootulp mentioned this issue Jul 25, 2022
Closed
4 tasks
@rootulp
Copy link
Collaborator

rootulp commented Jul 25, 2022

thanks for flagging @adlerjohn I created #560 and will investigate today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run proto-gen rootulp/celestia-app
3 participants
@adlerjohn @rootulp @evan-forbes