Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/140/get phenom #143

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Issue/140/get phenom #143

wants to merge 5 commits into from

Conversation

Mahir-Sparkess
Copy link
Contributor

fixes #140

@Mahir-Sparkess
Copy link
Contributor Author

Would it be possible the testCase for the list comprehension for int64 isn't reflective of a real value i.e. testCase is not a nested loop vs real link is nested loop?
Added if statement to check for nested loops so both cases work.

@Mahir-Sparkess
Copy link
Contributor Author

Check for dict instead of list, if it is a nested list then loop ends in 1 iteration, first item is dict (so not nested) any stops so iteration also ends in 1. therefore O(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsmith013 rsmith013 Awaiting requested review from rsmith013

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

500 errors on granules
1 participant
@Mahir-Sparkess