feat: improved instance docs #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * The EC2 attributes that come directly from the pricing API. | ||
| */ | ||
| interface EC2InstanceAttributes { |
There was a problem hiding this comment.
Anywhere we can get these from instead of maintaining them ourselves?
There was a problem hiding this comment.
Well... they are available from the Pricing API. This could be another automatically generated Type available in the type lib. But, this would be a case of we'd need that to be available first so we could use it. For now, I think we keep it as-is and expand further in the type lib unless you disagree
| let allInstanceTypes: InstanceTypeInfo[] = []; | ||
| let nextToken: string | undefined; | ||
| // Create Pricing client | ||
| const pricingClient = new Pricing({ region: 'us-east-1' }); |
There was a problem hiding this comment.
I know I ask every time but what do we think about this - do we think instance types and their product attributes might be regional?
There was a problem hiding this comment.
Indeed they are different per region which warrants a bigger discussion.
derrike
force-pushed
the
feat/improved-instance-docs
branch
from
549195b to
3ce5402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more information to EC2 Instances and Sagemaker notebooks types.