Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% test coverage again + handling of test warnings #134

Merged
merged 2 commits into from
Jun 30, 2019

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jun 30, 2019

  • Some testing reworked to handle all warnings thrown during them.
  • Some warnings will still be thrown if your version of Click is less than v7.0 (fixed here - commit):
test/test_cli.py::test_apprise_cli
  /usr/lib64/python3.7/os.py:678: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 54516)>
    raise KeyError(key) from None
  /usr/lib64/python3.7/os.py:678: ResourceWarning: unclosed <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 54518)>
    raise KeyError(key) from None
  /usr/lib64/python3.7/os.py:678: ResourceWarning: unclosed <socket.socket fd=11, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 54520)>
    raise KeyError(key) from None
  /usr/lib/python3.7/site-packages/click/core.py:847: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 54522)>
    all_names.difference_update(param.opts)
  /usr/lib/python3.7/site-packages/click/core.py:847: ResourceWarning: unclosed <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 54524)>
    all_names.difference_update(param.opts)
  • Testing coverage back to 100%
  • Additional tests added to handle other edge cases associated with URLs

@caronc caronc merged commit f3d335b into master Jun 30, 2019
@caronc caronc deleted the test-coverage-100pct branch June 30, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant