Skip to content

Rename beginswith to startswith #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2015

Conversation

mweastwood
Copy link
Contributor

This fixes a v0.4 deprecation warning.

On a related note, did the changes in 996d7be break v0.3 compatibility? It seems to me the Dicts need the @compat macro applied to them.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 82b319f on mweastwood:master into * on carlobaldassi:master*.

@mweastwood
Copy link
Contributor Author

On a related note, did the changes in 996d7be break v0.3 compatibility? It seems to me the Dicts need the @compat macro applied to them.

Apparently not.

@carlobaldassi
Copy link
Owner

This fix would need @compat all over the changes, whenever Compat.jl implements it (I didn't check if it does already). It also needs to update the REQUIRE file to the appropriate version of Compat.

The syntax Dict{T,S}() was supported in julia 0.3, it's just the non-empty version Dict{T,S}(a=>b, c=>d...) which is new (and was in fact annotated with @compat where it's used, i.e. in the tests).

@mweastwood
Copy link
Contributor Author

This fix would need @compat all over the changes, whenever Compat.jl implements it (I didn't check if it does already). It also needs to update the REQUIRE file to the appropriate version of Compat.

using Compat defines startswith = Base.beginswith after a version check here. So I don't think the @compat macro is necessary for this change.

@mweastwood
Copy link
Contributor Author

Ok, I've updated the REQUIRE file.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 358de10 on mweastwood:master into * on carlobaldassi:master*.

@carlobaldassi
Copy link
Owner

Ah right you are, sorry. Can you squash the two commits? Then it's good to go.

@mweastwood
Copy link
Contributor Author

Squashed

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 348b231 on mweastwood:master into * on carlobaldassi:master*.

carlobaldassi added a commit that referenced this pull request Jan 14, 2015
Rename beginswith to startswith
@carlobaldassi carlobaldassi merged commit 718bc96 into carlobaldassi:master Jan 14, 2015
@carlobaldassi
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants