Fix deprecations #31
Fix deprecations #31
Conversation
Current coverage is 94.75%@@ master #31 diff @@
==========================================
Files 1 1
Lines 1132 1105 -27
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 1076 1047 -29
- Misses 56 58 +2
Partials 0 0
|
|
@tkelman, could you please review this PR? |
| @@ -4,137 +4,137 @@ function _precompile_() | |||
| precompile(ArgParse.call, (Array{Any, 1}, Type{ArgParse.ArgParseSettings},)) | |||
| precompile(ArgParse.import_settings, (ArgParse.ArgParseSettings, ArgParse.ArgParseSettings, Bool,)) | |||
| precompile(ArgParse.override_duplicates, (Array{ArgParse.ArgParseField, 1}, ArgParse.ArgParseField,)) | |||
| precompile(ArgParse.parse1_optarg, (ArgParse.ParserState, ArgParse.ArgParseSettings, ArgParse.ArgParseField, UTF8String, UTF8String,)) | |||
| precompile(ArgParse.parse1_optarg, (ArgParse.ParserState, ArgParse.ArgParseSettings, ArgParse.ArgParseField, String, String,)) | |||
There was a problem hiding this comment.
Compat.UTF8String will be less likely to impact precompilation effectiveness on 0.4
|
@tkelman, can we merge this? |
| @@ -252,6 +252,7 @@ function check_type(opt, T::Type, message::AbstractString) | |||
| end | |||
|
|
|||
| function warn_extra_opts(opts, valid_keys::Vector{Symbol}) | |||
|
|
|||
|
LGTM, but I don't have commit access here |
|
@ViralBShah, can you merge this? |
|
Hi @abhijithch, I'm the owner of the repo and I'll merge as soon as I manage to take a look, thanks. (Hopefully this weekend.) (@tkelman thanks for reviewing) |
|
Thanks, it took me a while since there's a segfault on 0.5 while testing, but it's unrelated. There are still some annoying warnings from TextWrap, but they are harder to fix at this time since apparently Compat doesn't have a definition for |
|
Tag a new release? |
|
Ah yes, now that TextWrap is also fixed I will, thanks for reminding me. |
|
This didn't update the minimum Compat version in REQUIRE. |
Fixes deprecations for
Julia v0.5.