Skip to content

Various fixes for compatibility with latest Julia #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

simonster
Copy link

  • contains(str, str) -> !isempty(search()) (maybe there is a better way?)
  • has(set, x) -> contains(set, x)
  • keys() now returns a KeyIterator, which breaks _warn_extra_opts because it
    wanted a Vector{Symbol}. Because the type parameter shouldn't be necessary
    and KeyIterator isn't exported from Base, I removed it.

Verified

This commit was signed with the committer’s verified signature.
SrdjanLL Srdjan Lulic
- contains(str, str) -> !isempty(search()) (maybe there is a better way?)
- has(set, x) -> contains(set, x)
- keys() now returns a KeyIterator, which breaks _warn_extra_opts because it
  wanted a Vector{Symbol}. Because the type declaration shouldn't be necessary
  and KeyIterator isn't exported from Base, I removed it.
@maleadt
Copy link
Contributor

maleadt commented May 2, 2013

Gah, I didn't see this PR and fixed most of them myself as well. Anyhow, I needed to fix something else, since search(string, char) doesn't seem to return a range where search(string, string) does:

-            eqrng = search(arg, '=')
-            i = first(eqrng)
-            j = last(eqrng) + 1
+            eq = search(arg, '=')
             if i != 0
-                opt_name = arg[3:i-1]
-                arg_after_eq = arg[j:end]
+                opt_name = arg[3:eq-1]
+                arg_after_eq = arg[eq+1:end]

simonster added 2 commits May 2, 2013 14:10

Verified

This commit was signed with the committer’s verified signature.
SrdjanLL Srdjan Lulic
@carlobaldassi
Copy link
Owner

Thanks guys, and sorry for the horrible delay! I included these changes in the repo, but I split them into different commits; closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants