fix(ui): show input field errors after scanning #1063
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdisalvo-crd
approved these changes
Mar 26, 2025
iFergal
deleted the
fix/DTIS-2058-SSI-URL-Persistent-error-despite-new-error-in-different-place
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't show the invalid URL error until the user had touched the input fields so they wouldn’t appear with errors on initial launch before doing anything.
But they could scan a QR code instead of using the input field, and this is probably more likely on mobile.
I’ve set it now that the error will show when you touch the input field OR you open the scanner for that field.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation