fix(ui): handle proposal to present delete or unknown credential #1057
+754
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFergal
commented
Mar 24, 2025
| {missingProposedCred ? ( | ||
| <></> | ||
| ) : ( | ||
| <IonIcon icon={chevronForward} /> |
There was a problem hiding this comment.
This is now a chevron and not an info icon
6 tasks
iFergal
commented
Mar 24, 2025
.../components/CredentialRequest/CredentialRequestInformation/CredentialRequestInformation.scss
Show resolved
Hide resolved
6 tasks
sdisalvo-crd
approved these changes
Mar 25, 2025
Base automatically changed from
fix/DTIS-2048-Accept-reject-buttons-after-threshold-met-if-we-didn-t-contrib-to-threshold-for-group-presentation
to
release/1.0.0
March 25, 2025 12:08
…6-Broken-UI-if-initiator-proposes-to-present-a-credential-we-have-deleted-or-have-not-accepted
iFergal
deleted the
fix/DTIS-2046-Broken-UI-if-initiator-proposes-to-present-a-credential-we-have-deleted-or-have-not-accepted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to a presentation request, it's possible the group initiator will propose a credential that does not exist in the wallet because it either has not been accepted yet (groups have thresholds), or it has been deleted by the member.
This adds feedback in the UI that the credential is missing, and you won't be able to try to open the credential details anymore. (This could be improved to allow opening since it's in the IPEX message, but I don't have scope for that right now) It also changes the CTA buttons to the simple
Okbutton to go back.Note, archived credentials cannot be proposed but if another member archives the credential, the flow remains unaffected.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review
Before
Screen.Recording.2025-03-24.at.10.13.54.AM.mov
After