Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credential request secondary cta has the old design #1053

Conversation

jimcase
Copy link
Contributor

@jimcase jimcase commented Mar 24, 2025

Description

Fix credential request secondary decline button styles

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

Browser

Before
Screenshot 2025-03-24 at 16 41 47 Screenshot 2025-03-24 at 17 33 27
After
Screenshot 2025-03-24 at 16 41 26 Screenshot 2025-03-24 at 17 32 19

Sorry, something went wrong.

@jimcase jimcase self-assigned this Mar 24, 2025
@jimcase jimcase requested review from iFergal and sdisalvo-crd March 24, 2025 15:44
jimcase added 2 commits March 24, 2025 17:31
color="primary"
/>
{deleteButtonIcon && (
<IonIcon
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do you know what screens still have the icon? I think in the new design, the icon is just gone in general so this part might be legacy code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, let me check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok delete identifier

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we shouldn't change this component. This is the delete button, and it was created with an icon on purpose. If we modify it for this specific case then we have to change it again whenever we will build the new Decline button. I understand we want to merge this today, but I don't think this would be the right approach.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im gonna create a follow up ticket with this new decline button

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries I'll do it.

Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and creating a follow up ticket to properly handle a new button for the page footer, dedicated to the decline action.

@jimcase jimcase merged commit 7156f38 into release/1.0.0 Mar 24, 2025
1 check passed
@iFergal iFergal deleted the DTIS-2038-Credential-request-secondary-CTA-has-the-old-design branch March 25, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants