-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: credential request secondary cta has the old design #1053
fix: credential request secondary cta has the old design #1053
Conversation
color="primary" | ||
/> | ||
{deleteButtonIcon && ( | ||
<IonIcon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do you know what screens still have the icon? I think in the new design, the icon is just gone in general so this part might be legacy code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh, let me check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok delete identifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we shouldn't change this component. This is the delete button, and it was created with an icon on purpose. If we modify it for this specific case then we have to change it again whenever we will build the new Decline button. I understand we want to merge this today, but I don't think this would be the right approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im gonna create a follow up ticket with this new decline button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries I'll do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving and creating a follow up ticket to properly handle a new button for the page footer, dedicated to the decline action.
Description
Fix credential request secondary decline button styles
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review
Design Review
Browser
Before
After